feat: Upgrade rubocop

Author: Daniela Lemow

Gemfile.lock

@@ -183,7 +183,7 @@ GEM
     http-cookie (1.0.5)
       domain_name (~> 0.5)
     http-form_data (2.3.0)
-    i18n (1.14.4)
+    i18n (1.14.5)
       concurrent-ruby (~> 1.0)
     io-console (0.6.0)
     irb (1.6.4)
@@ -226,7 +226,7 @@ GEM
       mime-types-data (~> 3.2015)
     mime-types-data (3.2023.0218.1)
     mini_mime (1.1.5)
-    minitest (5.22.2)
+    minitest (5.22.3)
     multi_json (1.15.0)
     mysql2 (0.5.6)
     net-imap (0.4.10)
@@ -265,7 +265,7 @@ GEM
       nio4r (~> 2.0)
     raabro (1.4.0)
     racc (1.7.3)
-    rack (2.2.8.1)
+    rack (2.2.9)
     rack-mini-profiler (3.3.0)
       rack (>= 1.2.0)
     rack-proxy (0.7.6)
@@ -352,21 +352,25 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.31.3)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.20.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
-      rubocop (~> 1.33)
-    rubocop-performance (1.17.1)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.19.1)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-performance (1.21.0)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rails (2.24.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
-    rubocop-rspec (2.22.0)
-      rubocop (~> 1.33)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (2.29.2)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
+      rubocop-rspec_rails (~> 2.28)
+    rubocop-rspec_rails (2.28.3)
+      rubocop (~> 1.40)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)

app/models/extraction_job.rb

@@ -5,7 +5,7 @@
 class ExtractionJob < ApplicationRecord
   include Job
 
-  EXTRACTIONS_FOLDER = "#{Rails.root}/extractions/#{Rails.env}".freeze
+  EXTRACTIONS_FOLDER = Rails.root.join("extractions/#{Rails.env}").to_s.freeze
 
   enum :kind, { full: 0, sample: 1 }, prefix: :is
 

app/models/harvest_report.rb

@@ -40,12 +40,12 @@ def completed?
   end
 
   %i[extraction transformation load delete].each do |process|
-    define_method("#{process}_running!") do
+    define_method(:"#{process}_running!") do
       super()
-      send(:update, "#{process}_start_time" => Time.zone.now) if send("#{process}_start_time").blank?
+      send(:update, "#{process}_start_time" => Time.zone.now) if send(:"#{process}_start_time").blank?
     end
 
-    define_method("#{process}_completed!") do
+    define_method(:"#{process}_completed!") do
       super()
       send(:update, "#{process}_end_time" => Time.zone.now)
     end
@@ -54,7 +54,7 @@ def completed?
   ## These queries are all done atomically on the database
   # To prevent race conditions when multiple sidekiq processes are updating the same report at the same time.
   METRICS.each do |metric|
-    define_method("increment_#{metric}!") do |amount = 1|
+    define_method(:"increment_#{metric}!") do |amount = 1|
       with_lock do
         send(:increment!, metric, amount)
       end

app/models/parameter.rb

@@ -7,7 +7,7 @@ class Parameter < ApplicationRecord
   enum :content_type, { static: 0, dynamic: 1, incremental: 2 }
 
   def evaluate(response_object = nil)
-    send("#{content_type}_evaluation", response_object)
+    send(:"#{content_type}_evaluation", response_object)
   end
 
   def static_evaluation(_response_object)

app/supplejack/transformation/raw_records_extractor.rb

@@ -18,7 +18,7 @@ def records(page_number)
       return [] if @documents[page_number.to_i].size_in_bytes > 10.megabytes
 
       begin
-        send("#{format.downcase}_extract", page_number)
+        send(:"#{format.downcase}_extract", page_number)
       rescue NoMethodError, Nokogiri::XML::XPath::SyntaxError
         []
       end

lib/tasks/fixtures.rake

@@ -14,7 +14,7 @@ namespace :fixtures do
     `bin/rails db:fixtures:load`
 
     puts 'Launching the extraction jobs...'
-    ExtractionJob.all.each do |job|
+    ExtractionJob.find_each do |job|
       job.create_folder
       ExtractionWorker.new.perform(job.id)
     end

spec/support/capybara.rb

@@ -8,7 +8,7 @@
     driven_by :rack_test
   end
 
-  config.before(:each, js: true, type: :system) do
+  config.before(:each, :js, type: :system) do
     driven_by :selenium_chrome_headless
   end
 end