Skip to content

Commit a0a9659

Browse files
authored
Merge pull request #158 from boostcampwm-2022/157-interviewee-interviewer-페이지-스타일링
interviewee, interviewer, waiting 페이지 스타일링
2 parents 3d10264 + b490e6d commit a0a9659

File tree

17 files changed

+153
-70
lines changed

17 files changed

+153
-70
lines changed

frontend/src/components/FeedbackEditBtns/FeedbackEditBtns.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import useCrudFeedback from '@hooks/useCrudFeedback';
55
import { ReactComponent as DeleteIcon } from '@assets/icon/delete.svg';
66
import { ReactComponent as EditIcon } from '@assets/icon/edit.svg';
77
import { ReactComponent as CheckIcon } from '@assets/icon/check.svg';
8-
import { iconSmStyle } from '@styles/commonStyle';
8+
import { iconSxStyle } from '@styles/commonStyle';
99
import { fbBtnContainer } from './FeedbackEditBtns.style';
1010

1111
interface Props {
@@ -21,15 +21,15 @@ const FeedbackEditBtn = ({ id, readOnly }: Props) => {
2121
<div css={fbBtnContainer}>
2222
{readOnly ? (
2323
<button onClick={handleStartEditFeedback}>
24-
<EditIcon {...iconSmStyle} fill="black" />
24+
<EditIcon {...iconSxStyle} fill="black" />
2525
</button>
2626
) : (
2727
<button onClick={handleEndEditFeedback}>
28-
<CheckIcon {...iconSmStyle} fill="black" />
28+
<CheckIcon {...iconSxStyle} fill="black" />
2929
</button>
3030
)}
3131
<button onClick={handleDeleteFeedback}>
32-
<DeleteIcon {...iconSmStyle} fill="black" />
32+
<DeleteIcon {...iconSxStyle} fill="black" />
3333
</button>
3434
</div>
3535
);

frontend/src/components/FeedbackForm/FeedbackForm.style.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const fbInputStyle = (theme) => css`
2121
`;
2222

2323
export const fbStartTimeStyle = (theme) => css`
24-
width: 30px;
24+
width: 45px;
2525
height: 15px;
2626
font-size: 12px;
2727
border-radius: 2px;

frontend/src/components/FeedbackForm/FeedbackForm.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1+
import { ONE_SECOND } from '@constants/time.constant';
12
import { EditableFeedbackType } from '@customType/feedback';
23
import { currentVideoTimeState } from '@store/currentVideoTime.store';
34
import { feedbackIdsState, feedbackIdxMapState, feedbackState } from '@store/feedback.store';
5+
import { mmssFormatter } from '@utils/common.util';
46
import React, { useState } from 'react';
57
import { useRecoilTransaction_UNSTABLE, useRecoilValue } from 'recoil';
68

@@ -57,7 +59,9 @@ const FeedbackForm = () => {
5759

5860
return (
5961
<div css={fbFormWrapperStyle}>
60-
<div css={fbStartTimeStyle}>{inputVal ? startTime : currentVideoTime}</div>
62+
<div css={fbStartTimeStyle}>
63+
{mmssFormatter((inputVal ? startTime : currentVideoTime) * ONE_SECOND)}
64+
</div>
6165
<textarea
6266
value={inputVal}
6367
onKeyDown={handleKeyDown}

frontend/src/components/FeedbackItem/FeedbackItem.style.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const fbTextAreaStyle = (theme) => css`
1717
`;
1818

1919
export const fbStartTimeStyle = (theme) => css`
20-
width: 30px;
20+
width: 45px;
2121
height: 15px;
2222
font-size: 12px;
2323
border-radius: 2px;

frontend/src/components/FeedbackItem/FeedbackItem.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,8 @@ const FeedbackItem = ({ feedback, feedbackRef, index, editableBtns }: Props) =>
2626
const { handleFbChange } = useCrudFeedback(feedback.id);
2727

2828
useEffect(() => {
29-
const effect = () => {
30-
if (!feedbackRef) return;
29+
if (feedbackRef)
3130
feedbackRef.current[index].style.height = textareaRef.current.scrollHeight + 'px';
32-
};
33-
effect();
3431
});
3532

3633
const { startTime, isFirst, content, readOnly } = feedback;
@@ -41,13 +38,8 @@ const FeedbackItem = ({ feedback, feedbackRef, index, editableBtns }: Props) =>
4138
setCurrentVideoTime(startTime);
4239
};
4340

44-
const getFbRef = (el) => {
45-
if (!feedbackRef) return;
46-
return (feedbackRef.current[index] = el);
47-
};
48-
4941
return (
50-
<div ref={getFbRef} css={feedbackBoxStyle}>
42+
<div ref={(el) => (feedbackRef.current[index] = el)} css={feedbackBoxStyle}>
5143
<div css={fbStartTimeStyle} style={{ visibility: isFirst ? 'visible' : 'hidden' }}>
5244
{mmssFormatter(startTime * ONE_SECOND)}
5345
</div>

frontend/src/constants/page.constant.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ export enum PAGE_TYPE {
55
INTERVIEWER_PAGE = 'interviewer',
66
INTERVIEWEE_PAGE = 'interviewee',
77
FEEDBACK_PAGE = 'feedback',
8-
WAITTING_PAGE = 'waitting',
8+
WAITTING_PAGE = 'waiting',
99
}

frontend/src/constants/route.constant.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ export enum ROUTE_TYPE {
55
INTERVIEWER_ROUTE = '/interviewer',
66
INTERVIEWEE_ROUTE = '/interviewee',
77
FEEDBACK_ROUTE = '/feedback',
8-
WAITTING_ROUTE = '/waitting',
8+
WAITTING_ROUTE = '/waiting',
99
}

frontend/src/pages/Feedback/Feedback.style.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const feedbackWrapperStyle = (theme) => css`
77
background-color: ${theme.colors.tertiary};
88
`;
99

10-
export const feedbackPageContainerStyle = css`
10+
export const feedbackContainerStyle = css`
1111
height: 100%;
1212
display: flex;
1313
gap: 25px;
@@ -19,9 +19,9 @@ export const feedbackPageContainerStyle = css`
1919

2020
export const feedbackSyncBtnStyle = (theme, isFbSync) => css`
2121
background-color: ${isFbSync ? theme.colors.primary : theme.colors.white};
22-
width: 50;
23-
height: 50;
24-
border-radius: '25px';
22+
width: 50px;
23+
height: 50px;
24+
border-radius: 50%;
2525
display: 'flex';
2626
justify-content: 'center';
2727
align-items: 'center';

frontend/src/pages/Feedback/Feedback.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { ReactComponent as LinkIcon } from '@assets/icon/link.svg';
1515
import { socket } from '../../service/socket';
1616
import {
1717
feedbackWrapperStyle,
18-
feedbackPageContainerStyle,
18+
feedbackContainerStyle,
1919
feedbackAreaStyle,
2020
feedbackSyncBtnStyle,
2121
} from './Feedback.style';
@@ -81,7 +81,7 @@ const Feedback = () => {
8181

8282
return (
8383
<div css={feedbackWrapperStyle}>
84-
<div css={feedbackPageContainerStyle}>
84+
<div css={feedbackContainerStyle}>
8585
<IntervieweeVideo src={videoUrl} width={400} autoplay muted controls />
8686
<button
8787
css={(theme) => feedbackSyncBtnStyle(theme, isFbSync)}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { css } from '@emotion/react';
2+
3+
export const intervieweeWrapperStyle = (theme) => css`
4+
width: 100%;
5+
height: 100%;
6+
background-color: ${theme.colors.tertiary};
7+
`;

0 commit comments

Comments
 (0)