-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sensor errors related to empty GraphQL query #1573
Conversation
PR Summary
|
/integration sha=241f3b6efb35583316e32bb23312e80fe08ac492 |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved it, but the integration tests should pass before merging
❌ Oh no! Integration tests have failed |
/integration sha=f331c1b4c84dce91559062c5a5444682550f0fbd |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
Description
Some health sensor endpoints require making an empty request to the GraphQL endpoint. Making this request with an empty body caused errors which caused other sensors to appear without response. (e.g., returned an empty array):
This PR fixes this error by sending a minimal GraphQL query in the request body.
Changes
health-adapter.ts
in both Azure and local providers so thatisGraphQLFunctionUp
method sends the following in the request body: