Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sensor errors related to empty GraphQL query #1573

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

MarcAstr0
Copy link
Collaborator

Description

Some health sensor endpoints require making an empty request to the GraphQL endpoint. Making this request with an empty body caused errors which caused other sensors to appear without response. (e.g., returned an empty array):

error: [Booster]|BoosterGraphQLDispatcher#runGraphQLOperation: Received an empty GraphQL query

This PR fixes this error by sending a minimal GraphQL query in the request body.

Changes

  • Modifies health-adapter.ts in both Azure and local providers so that isGraphQLFunctionUp method sends the following in the request body:
{
  "query": "query { __typename }",
}

@MarcAstr0 MarcAstr0 added the bug Something isn't working label Mar 24, 2025
@MarcAstr0 MarcAstr0 requested a review from davidverdu March 24, 2025 19:56
Copy link

what-the-diff bot commented Mar 24, 2025

PR Summary

  • Added Documentation for Sensor Fixes
    A new file has been added, named fix_sensors_2025-03-24-19-38.json. This file provides detailed documentation related to updates and problem-solving efforts around the behavior of certain sensors in our system.

  • Updated Software Dependencies
    We've updated the specifications for numerous software components that our system relies on. These updates appear in a file called pnpm-lock.yaml and involve several system packages. The goal here is to keep up-to-date with advancements in these software components and benefit from any improvements made.

  • TypeScript Version Upgrade
    TypeScript is a programming language we use, and we've upgraded to a newer developmental version. This could allow us to build more feature-rich and secure applications.

  • Improved Data Request Handling
    We've changed how our system handles certain types of data requests (specifically, GraphQL requests) in particular system components (framework-provider-azure and framework-provider-local). The modification aims to include more detailed information in the request, which may result in better system performance and reliability.

@MarcAstr0
Copy link
Collaborator Author

/integration sha=241f3b6efb35583316e32bb23312e80fe08ac492

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it, but the integration tests should pass before merging

Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=f331c1b4c84dce91559062c5a5444682550f0fbd

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 merged commit 3e55a7a into boostercloud:main Mar 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants