Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation details of cpp files should not fo to include directory #126

Closed
akrzemi1 opened this issue Jan 19, 2024 · 0 comments · Fixed by #146
Closed

Implementation details of cpp files should not fo to include directory #126

akrzemi1 opened this issue Jan 19, 2024 · 0 comments · Fixed by #146

Comments

@akrzemi1
Copy link
Member

If file https://github.com/cppalliance/charconv/blob/0e9dbf273d215ca717ae98f36e9c15d4f88934c2/include/boost/charconv/detail/compute_float64.hpp#L1[compute_float64.hpp] is only included from the cpp files in src directory, I do not think it should be exposed in include directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Post-Review Refactoring boostorg/charconv
1 participant
@akrzemi1