Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add boost::circular_buffer serialization #24

Open
yuvalif opened this issue Nov 30, 2018 · 3 comments
Open

feature request: add boost::circular_buffer serialization #24

yuvalif opened this issue Nov 30, 2018 · 3 comments

Comments

@yuvalif
Copy link

yuvalif commented Nov 30, 2018

For possible implementation and benchmarking please see here.

@robertramey
Copy link
Member

In order to get this in, I'd recommend the following. This library is maintained, but I doubt the maintainer can spare the time for a non-trivial enhancement such as this. So, if this is important to you, I recommend that you:

a) fork the library
b) add your implementation to the code
c) update the documentation
d) add a test of serialization

create a pull request.

What's in it for you?

a) you get the enhancement to the library that you need.
b) you get can put your name on the copyright of the serialization code and the test and a note in the documentation.
c) so you can proudly wear the title of official boost library maintainer - which can look good on your resume,
d) the eternal gratitude of those who come after you.

@yuvalif
Copy link
Author

yuvalif commented Dec 18, 2018

@robertramey sounds like a plan :-)

@yuvalif
Copy link
Author

yuvalif commented Jan 31, 2019

This is implemented in PR #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants