-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1D Newton iteration count issue(s) #1008
Comments
Because of the issue described above, the unit test Lines 657 to 659 in 50ef83a
|
This was referenced Jul 31, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for
newton_raphson_iterate
says:There are two issues relating to
max_iter
:max_iter
is copied to a variablecount
. After each Newton iteration, one is subtracted fromcount
. Because of thedo {...} while (count && ...)
structure of the Newton iteration, ifmax_iter = 0
, rollover occurs, makingmax_iter
functionally infinite.0 < max_iter
, running out of iterations exits the Newton loop as if the tolerance was met.These two observations are demonstrated in the code below.
The text was updated successfully, but these errors were encountered: