-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow/underflow in quaternion and octanion division operator #1202
Comments
While this should get fixed have you tried Boost.QVM (https://www.boost.org/doc/libs/1_86_0/libs/qvm/doc/html/index.html)? I believe it has a much richer set of support than our quaternions (which is the oldest part of the library) |
Thank you for sharing about QVM. Here is how I discovered this problem. |
Overflow or underflow occurs when the divisor is a giant or minute number in quaternion and octanion division.
The following code, which is expected to yield 1, unexpectedly yields NaN.
I consider exponential normalization to be necessary in the following code.
denominator
underflows or overflows whenrhs
is a minute or huge number.Quaternion:
math/include/boost/math/quaternion.hpp
Lines 398 to 420 in c3afa49
Octanion:
math/include/boost/math/octonion.hpp
Lines 561 to 654 in c3afa49
The text was updated successfully, but these errors were encountered: