Skip to content

Commit ae013c1

Browse files
committed
Document errors and async_run
1 parent ae7efd5 commit ae013c1

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

include/boost/redis/connection.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -592,6 +592,8 @@ class basic_connection {
592592
* This function establishes a connection to the Redis server and keeps
593593
* it healthy by performing the following operations:
594594
*
595+
* @li For Sentinel deployments (`config::sentinel::addresses` is not empty),
596+
* contacts Sentinels to obtain the address of the configured master.
595597
* @li For TCP connections, resolves the server hostname passed in
596598
* @ref boost::redis::config::addr.
597599
* @li Establishes a physical connection to the server. For TCP connections,

include/boost/redis/error.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@ enum class error
9898
/// The configuration specified UNIX sockets with Sentinel, which is not supported.
9999
sentinel_unix_sockets_unsupported,
100100

101-
// TODO: document
101+
/// No Sentinel knows about the master configured in `config::sentinel::master_name`.
102102
sentinel_unknown_master,
103103

104-
// TODO: document
104+
/// No Sentinel could be contacted to obtain the address of the Redis server.
105105
no_sentinel_reachable,
106106

107-
// TODO: document
108-
// TODO: should this ever be returned to the user?
107+
/// The contacted server is not a master as expected.
108+
/// This is likely a transient failure caused by a Sentinel failover in progress.
109109
role_check_failed,
110110
};
111111

0 commit comments

Comments
 (0)