Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost Progress #12

Closed
r-barnes opened this issue Aug 19, 2019 · 8 comments
Closed

Boost Progress #12

r-barnes opened this issue Aug 19, 2019 · 8 comments

Comments

@r-barnes
Copy link

boost/progress.hpp warns me:

include/boost/timer.hpp:21:98: note: #pragma message: This header is deprecated. 
Use the facilities in <boost/timer/timer.hpp> instead.
BOOST_HEADER_DEPRECATED( "the facilities in <boost/timer/timer.hpp>" )

But when I look in boost/timer.hpp there's no obvious path to upgrade, since there is no boost::progress_display class.

How am I intended to deal with the deprecation of progress.hpp, other than rewriting it?

@pdimov
Copy link
Member

pdimov commented Aug 21, 2019

Fair point. I added the deprecation message because the old timers have been explicitly marked as deprecated in the documentation for a long while (since Boost 1.53, https://www.boost.org/doc/libs/1_53_0/libs/timer/doc/index.html.)

But it's true that progress_display has no "modern" equivalent.

I'm not sure what's the best way to handle this; add boost::timer::progress_display with the same contents as the deprecated one?

@glenfe
Copy link
Member

glenfe commented Aug 21, 2019

Adding boost::timer::progress_display in a new header, <boost/timer/progress_display.hpp>. With the same contents is fine. I don't think we're using it in other Boost libraries, and users are probably already aware that it won't receive updates (though contributions wouldn't be turned away).

@r-barnes
Copy link
Author

This seems reasonable to me.

@r-barnes
Copy link
Author

Should I make a PR?

@pdimov
Copy link
Member

pdimov commented Aug 24, 2019

No need, thanks. See c221a60.

@r-barnes
Copy link
Author

Cool, I'll close this then.

@r-barnes
Copy link
Author

Oh - I wonder if you know when that might make it into a Boost release?

@r-barnes r-barnes reopened this Aug 27, 2019
@glenfe
Copy link
Member

glenfe commented Aug 27, 2019

It should make it into 1.72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants