Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing iteration-type of for-loop. #165

Open
amitsingh19975 opened this issue Feb 11, 2022 · 3 comments
Open

Fixing iteration-type of for-loop. #165

amitsingh19975 opened this issue Feb 11, 2022 · 3 comments

Comments

@amitsingh19975
Copy link
Collaborator

The current loops rely on auto deduction or integer suffix for the type that may not be a correct iteration type and may produce conversion warnings all over places. Therefore, I propose to remove auto from the loops and use appropriate and explicit types or use explicit types to initialize the variable. In a long run, it would produce a bug-free code, and it would remove all warnings produced by compilers.

From

for(auto d = 0u; d < t.size(); ++d)
{
...
}

To

for(auto d = size_type{0}; d < t.size(); ++d)
{
...
}
@Neel-Shah-29
Copy link
Contributor

Neel-Shah-29 commented Feb 11, 2022

Can I take up this issue if no one is working upon it. Kindly assign it to me

@amitsingh19975
Copy link
Collaborator Author

amitsingh19975 commented Feb 11, 2022

Can I take up this issue if no one is working upon it. Kindly assign it to me

I'm waiting for others' views on this. Therefore, wait for a few days. So, I request you to read the tensor's codebase and try to find bugs or enhancements that you think would improve the tensor. Finding bugs is also a way to contribute.

@Neel-Shah-29
Copy link
Contributor

Neel-Shah-29 commented Feb 19, 2022

Since 20 days, if no one is putting input over this issue , Can i take up this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants