Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check how Danger determines whether tests have been added. #515

Open
lcreid opened this issue Jan 31, 2019 · 1 comment
Open

Check how Danger determines whether tests have been added. #515

lcreid opened this issue Jan 31, 2019 · 1 comment

Comments

@lcreid
Copy link
Contributor

lcreid commented Jan 31, 2019

PR #513 added a test in a new file, but Danger reported that no tests had been added. Make sure Danger correctly identifies if tests have been added.
@lcreid
Copy link
Contributor Author

lcreid commented Jan 31, 2019

Without having tested: It appears that Danger's modified files are files that were existing and have changed. There is also an added_files method, that would presumably return something for added files. The Dangerfile currently only checks modified files. Ideally we'd check added_files too, but it's not something that's going to happen very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcreid