Fix text alignment in alert message when there is no error summary #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no error summary the alert message is wrapped in a p tag. This causes the message to be misaligned vertically. In the Bootstrap examples where there is single line of text, the text is not wrapped in a p tag: https://getbootstrap.com/docs/5.0/components/alerts/#examples
|
Thanks for catching this, and thanks for the PR. It looks good, but I'd appreciate it if you can fix the test cases so they all pass. Don't worry about the Danger test failing -- there's an issue with Danger on GitHub that doesn't seem to have a solution, but we haven't disabled Danger yet. Sorry. |
|
@isaac Thanks for the PR! Could you fix the one failing test case and rebase against main? |
|
Sorry for the slow response! I couldn't find a failing test case - has this already been fixed somewhere else? |
|
@isaac Yes, I fixed it 😄 |
|
Examples in thre README: https://github.com/bootstrap-ruby/bootstrap_form#alert-messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no error summary the alert message is wrapped in a p tag. This causes the message to be misaligned vertically. In the Bootstrap examples where there is single line of text, the text is not wrapped in a p tag: https://getbootstrap.com/docs/5.0/components/alerts/#examples
Screenshots below illustrate the issue.
Before fix:
After fix: