Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-file): Add prop to allow customization of browse button text. fixes #2143 #2168

Merged
merged 6 commits into from
Nov 13, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 13, 2018

Description of Pull Request:

Adds new prop to customize browse button text.

Includes temporary CSS until Bootstrap V4.2 is released

fixes #2143

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Adds new prop to customize browse button text.

Includes temporary CSS until Bootstrap V4.2 is released
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #2168 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2168   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files         158      158           
  Lines        2998     2998           
  Branches      832      832           
=======================================
  Hits         1979     1979           
  Misses        739      739           
  Partials      280      280
Impacted Files Coverage Δ
src/components/form-file/form-file.js 10.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805a7fe...6da8837. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(form-file): Add prop to allow customization of browse button text fix(form-file): Add prop to allow customization of browse button text. fixes #2143 Nov 13, 2018
@tmorehouse tmorehouse merged commit 56c26da into dev Nov 13, 2018
@tmorehouse tmorehouse deleted the tmorehouse/file-input branch November 13, 2018 20:57
@tmorehouse tmorehouse mentioned this pull request Nov 14, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to customise the button text of "Browse" in b-form-file
1 participant