Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): set default total rows to 0 (fixes #2498) #2526

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Sets total-rows default value to 0.

fixes #2498

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

Fixes `total-rows` default value to 0
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #2526 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2526   +/-   ##
=======================================
  Coverage   71.65%   71.65%           
=======================================
  Files         172      172           
  Lines        3239     3239           
  Branches      916      916           
=======================================
  Hits         2321     2321           
  Misses        666      666           
  Partials      252      252
Impacted Files Coverage Δ
src/components/pagination/pagination.js 50% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523e3a2...4e10d26. Read the comment docs.

@tmorehouse
Copy link
Member Author

One weird thing is when the value is defaulted to 0, the component property reference section does not show.

May need to add a separate PR to handle that case.

@tmorehouse
Copy link
Member Author

The component props reference appears to be foobarred before this.

@tmorehouse tmorehouse merged commit c3227a6 into dev Feb 12, 2019
@tmorehouse tmorehouse deleted the tmorehouse/pagination-rows branch February 12, 2019 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong pagination counts
1 participant