-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): fix initial value handling (closes #2656) #2661
fix(tabs): fix initial value handling (closes #2656) #2661
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2661 +/- ##
=========================================
+ Coverage 71.92% 74% +2.07%
=========================================
Files 173 173
Lines 3199 3201 +2
Branches 938 939 +1
=========================================
+ Hits 2301 2369 +68
+ Misses 655 610 -45
+ Partials 243 222 -21
Continue to review full report at Codecov.
|
For this one, I think I might add in a few extra tests for functionality (by including a few |
Description of Pull Request:
This PR fixes the initial
value
(v-model) handling by wrapping the firstupdateTabs()
call in thecreated()
hook in a$nextTick()
to make sure that the tabs have been created.Some initial test for the
<b-tabs>
component are added to back this up.Closes #2656.
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOG
is generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.json
for slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)