Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add back missing leading slash to search urls (closes #2945) #2947

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

jacobmllr95
Copy link
Member

Description of Pull Request:

#2893 introduces a change to docs/components/search.vue that removed the leading slash from the URL of the search results. This results in a 404 when clicking on the search result.

This PR adds the slash back and fixes the issue.

Closes #2945.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #2947 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2947   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         205      205           
  Lines        3247     3247           
  Branches      959      959           
=======================================
  Hits         2989     2989           
  Misses        190      190           
  Partials       68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8058c03...9c917cd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #2947 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2947   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         205      205           
  Lines        3247     3247           
  Branches      959      959           
=======================================
  Hits         2989     2989           
  Misses        190      190           
  Partials       68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8058c03...9c917cd. Read the comment docs.

@jacobmllr95 jacobmllr95 merged commit fff8795 into bootstrap-vue:dev Mar 29, 2019
@jacobmllr95 jacobmllr95 deleted the fix-docs-search branch March 29, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap-vue website doesn't search correctly
1 participant