Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-pagination-nav): attempt to auto-detect current page when pages array or number-of-pages changes (closes #3443) #3444

Merged
merged 3 commits into from
Jun 4, 2019

Conversation

tmorehouse
Copy link
Member

Describe the PR

Closes #3443

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

…s` array or `number of pages` changes (closes #3443)


Closes #3443
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #3444 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3444   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files         221      221           
  Lines        4215     4215           
  Branches     1216     1216           
=======================================
  Hits         4183     4183           
  Misses         26       26           
  Partials        6        6
Impacted Files Coverage Δ
src/components/pagination-nav/pagination-nav.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4287ddf...212861a. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review June 4, 2019 19:55
@tmorehouse tmorehouse requested a review from jacobmllr95 June 4, 2019 19:56
@tmorehouse tmorehouse changed the title fix(b-pagination-nav): attempt to auto-detect current page when pages array or number of pages changes (closes #3443) fix(b-pagination-nav): attempt to auto-detect current page when pages array or number-of-pages changes (closes #3443) Jun 4, 2019
@tmorehouse tmorehouse merged commit 88b95c6 into dev Jun 4, 2019
@tmorehouse tmorehouse deleted the issue/3443 branch June 4, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<b-pagination-nav> fails to update the active page when "pages" gets larger
2 participants