feat: improved tree-shaking when importing individual components #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3462 +/- ##
==========================================
+ Coverage 99.24% 99.25% +0.01%
==========================================
Files 222 224 +2
Lines 4213 4300 +87
Branches 1225 1226 +1
==========================================
+ Hits 4181 4268 +87
Misses 26 26
Partials 6 6
Continue to review full report at Codecov.
|
tmorehouse
changed the title
jacobmllr95
reviewed
Jun 8, 2019
jacobmllr95
reviewed
Jun 8, 2019
tmorehouse
changed the title
tmorehouse
changed the title
tmorehouse
changed the title
jacobmllr95
approved these changes
Jun 10, 2019
alphebetize plugins
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Create simple plugin object factory function, which can be marked as
/*#__PURE__*/when exporting a plugin (safe for exclusion with no side effects). Rollup and Webpack/Terser will sometimes not exclude exports that are results of function calls, as they are unsure if the function call has any side effects, so whenever we callVue.extend(..),pluginFactory(...), orinstallFactory(...), we prefix it with a/*#__PURE__*/comment. For better tree shaking and dead code elimination (DCE) ofdist/bootstrap-vue.esm.jsbundle (if anyone uses it, and is doing selective imports). Based on https://iamakulov.com/notes/polished-webpack/Also includes a tweak for component and directive top level exports for even better individual component/directive import tree-shaking (until Webpack v5 is released: webpack/webpack#9203, webpack/webpack#8057)
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: