Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 18, 2019

Describe the PR

b-nav-item-dropdown wasn't closing the menu on second click of the toggler, unlike b-dropdown

One Issue was that there was a check for toggle event defaultPrevented (native event), and b-link when HREF is '#' prevents default to stop scroll to top behaviour, which prevents b-nav-item-dropdown from closing the menu.

Removed the check for defaultPrevented in dropdown mixin.

The other issue was that focusInHandler() used this.$refs.toggle to check wether the event target is contained. this.$refs.toggle can be a component in some places. Using the computed toggler property for the check solved the problem.

Closes #3707.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #3706 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3706      +/-   ##
==========================================
- Coverage   99.29%   99.29%   -0.01%     
==========================================
  Files         223      223              
  Lines        4378     4377       -1     
  Branches     1237     1235       -2     
==========================================
- Hits         4347     4346       -1     
  Misses         25       25              
  Partials        6        6
Impacted Files Coverage Δ
src/components/nav/nav-item-dropdown.js 100% <ø> (ø) ⬆️
src/mixins/dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37be20b...d63afcd. Read the comment docs.

@tmorehouse tmorehouse changed the title fi(b-nav-item-dropdown): clicking toggle a second time should close menu fix(b-nav-item-dropdown): clicking toggle a second time should close menu Jul 18, 2019
@jacobmllr95 jacobmllr95 changed the title fix(b-nav-item-dropdown): clicking toggle a second time should close menu fix(b-nav-item-dropdown): clicking toggle a second time should close menu (closes #3707) Jul 18, 2019
@jacobmllr95 jacobmllr95 marked this pull request as ready for review July 18, 2019 20:23
@jacobmllr95 jacobmllr95 self-requested a review July 18, 2019 20:24
@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Jul 18, 2019
@jacobmllr95 jacobmllr95 self-requested a review July 19, 2019 01:52
@jacobmllr95 jacobmllr95 merged commit 629951e into dev Jul 19, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/nav-dd branch July 19, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Patch Requires patch version bump Type: Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<b-nav-item-dropdown>: Flickers when trying to close with click on dropdown

2 participants