-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-nav-item-dropdown): clicking toggle a second time should close menu (closes #3707) #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3706 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 223 223
Lines 4378 4377 -1
Branches 1237 1235 -2
==========================================
- Hits 4347 4346 -1
Misses 25 25
Partials 6 6
Continue to review full report at Codecov.
|
jacobmllr95
reviewed
Jul 18, 2019
jacobmllr95
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
b-nav-item-dropdown
wasn't closing the menu on second click of the toggler, unlikeb-dropdown
One Issue was that there was a check for toggle event
defaultPrevented
(native event), andb-link
when HREF is '#' prevents default to stop scroll to top behaviour, which preventsb-nav-item-dropdown
from closing the menu.Removed the check for
defaultPrevented
in dropdown mixin.The other issue was that
focusInHandler()
usedthis.$refs.toggle
to check wether the event target is contained.this.$refs.toggle
can be a component in some places. Using the computedtoggler
property for the check solved the problem.Closes #3707.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: