-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tables): ensure row variant active
(class table-active
) takes precedence over other row variants (addresses #3008)
#4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other row variants
Codecov Report
@@ Coverage Diff @@
## dev #4127 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 238 238
Lines 4471 4471
Branches 1260 1260
=======================================
Hits 4465 4465
Misses 5 5
Partials 1 1 Continue to review full report at Codecov.
|
tmorehouse
changed the title
fix(tables): ensure row variant
fix(tables): ensure row variant Sep 19, 2019
table-active
takes precedence over other row variantstable-active
takes precedence over other row variants (addresses #3008)
tmorehouse
changed the title
fix(tables): ensure row variant
fix(tables): ensure row variant Sep 19, 2019
table-active
takes precedence over other row variants (addresses #3008)active
(class table-active
) takes precedence over other row variants (addresses #3008)
…p-vue/bootstrap-vue into tmorehouse/table-active
jacobmllr95
approved these changes
Sep 19, 2019
This was referenced Sep 29, 2019
This was referenced Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Re-declares the
table-active
row variant class after any other row-variant classes so that it can take precedence when using it as theselected-variant
for selectable rows.Addresses #3008 (but only when using
selected-variant="active"
)To Do:
:hover
style handling fortable-active
/bg-active
row variant class (borrow from sticky column hover handling)PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: