-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(b-table, b-table-lite): improve render performance (closes #4211, #4155) #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorehouse
added
Type: Perf
Type: Refactor
Status: WIP
PR: Patch
Requires patch version bump
labels
Oct 7, 2019
Codecov Report
@@ Coverage Diff @@
## dev #4213 +/- ##
==========================================
+ Coverage 99.86% 99.86% +<.01%
==========================================
Files 237 237
Lines 4525 4534 +9
Branches 1274 1280 +6
==========================================
+ Hits 4519 4528 +9
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
tmorehouse
changed the title
perf(b-table, b-table-lite): improve render performance
perf(b-table, b-table-lite): improve render performance (closes #4211, #4155)
Oct 8, 2019
This was referenced Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Improve performance of
<b-table>
and<b-table lite>
by using nativetd
/th
in table<tbody>
if the cell is not a sticky column (otherwise use ab-th
/b-td
where the instance intelligence is needed to handle cell variants for sticky columns)This can dramatically reduce the number of Vue instances instantiated for extremely large tables (where overall cell counts are in the 1000's)
Closes #4211
Closes #4155
Might address #4150
Side note: if bootstrap v5 incorporates the proposed cell background inheritance, then our child helper components can be converted to functional components (which will further improve performance and remove the need for injection resolution)
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: