feat(b-form-datepicker): add button-content optionally scoped slot for icon

[andrewvasilchuk]

Describe the PR

Add support for button-content slot, which will allow consumers to specify their own button icon/content.

PR checklist

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Enhancement
• ARIA accessibility
• Documentation update
• Other (please describe)

Does this PR introduce a breaking change? (check one)

• No
• Yes (please describe)

The PR fulfills these requirements:

• It's submitted to the dev branch, not the master branch
• When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
• It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
• The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

• Includes documentation updates (including updating the component's package.json for slot and event changes)
• Includes any needed TypeScript declaration file updates
• New/updated tests are included and passing (if required)
• Existing test suites are passing
• CodeCov for patch has met target
• The changes have not impacted the functionality of other components or directives
• ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

• A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

[codecov]

Codecov Report

Merging #4795 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4795   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         263      263           
  Lines        5857     5857           
  Branches     1528     1528           
=======================================
  Hits         5853     5853           
  Misses          3        3           
  Partials        1        1

Impacted Files	Coverage Δ
src/components/tabs/tab.js	100% <ø> (ø)	⬆️
src/components/tabs/tabs.js	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6be3d3...77ef71b. Read the comment docs.

[tmorehouse]

We will wait to merge this, in case we need to release a patch version to v2.5.0 before v2.6.0

[andrewvasilchuk]

Wow, guys, you are so fast. Do I need to do something else? Thanks you a lot 🙏.

[jacobmllr95]

@andrewvasilchuk I think we are fine here now. Thanks :)

[tmorehouse]

The only issue with using || instead of a ternary, is that if the slot returns '' it will render the default icon.

[jacobmllr95]

@tmorehouse Hmm, haven't thought about that.

[tmorehouse]

We can always leave as-is for now, and people have issues we can use the hasNormalizedSlot check.

[leachimsumiri]

what's the syntax for the button-content slot?

[leachimsumiri]

got it, it's

<template v-slot:button-content>
</template>