Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Update templates dist #59

Closed
Waxolunist opened this issue Sep 29, 2014 · 4 comments
Closed

[CLOSED] Update templates dist #59

Waxolunist opened this issue Sep 29, 2014 · 4 comments
Labels
Milestone

Comments

@Waxolunist
Copy link
Contributor

Issue by corbinu
Thursday Jun 19, 2014 at 05:59 GMT
Originally opened as Waxolunist/bootstrap3-wysihtml5-bower#59


The templates dist file has not been updated in v0.3.1 The AMD version is fine but the regular one lacks the new template updates like the font awesome support.

@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Thursday Jun 19, 2014 at 16:20 GMT


Oh I am sorry. I will update the version as soon as possible. Probably this evening (CET).

@Waxolunist Waxolunist added this to the v0.3.1 milestone Sep 29, 2014
@Waxolunist Waxolunist added the bug label Sep 29, 2014
@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Thursday Jun 19, 2014 at 21:21 GMT


Which files do you mean exactly?
I can see for instance the class "fa-indent" here: https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.1/dist/bootstrap3-wysihtml5.all.js#L14055

What is wrong, is that an old copy of the 0.2.x source files were checked into the dist folder.
That is due to a missing delete job upon build.

@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Thursday Jun 19, 2014 at 21:46 GMT


Ok, I think I have it solved now.
I updated the Grunttask to copy the generated files from the generated folder to the dist folder.

It took me 3 pushes to get it done. I think I am going to sleep now. ;)

Thx for reporting and sorry for the inconvenience.
You should in your bower project redownload the version 0.3.1.

@Waxolunist
Copy link
Contributor Author

Comment by corbinu
Thursday Jun 19, 2014 at 22:33 GMT


Thanks looks great no need to be sorry thanks for such a quick response

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant