Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets of dependency are ignored #372

Closed
boozook opened this issue May 31, 2024 · 1 comment · Fixed by #376
Closed

Assets of dependency are ignored #372

boozook opened this issue May 31, 2024 · 1 comment · Fixed by #376
Labels
assets Assets Build System bug Something isn't working cargo About cargo or cargo-playdate

Comments

@boozook
Copy link
Owner

boozook commented May 31, 2024 •
edited
Loading

cargo-playdate versions:
reproduced with 0.4.14

Steps to reproduce:

  1. mkdir issue-372; cd $_
  2. cargo playdate init --lib
  3. cargo add playdate-ui-crank-indicator
  4. ensure that package.metadata.playdate.options.assets.dependencies = true
  5. CARGO_PLAYDATE_LOG="trace" RUST_LOG="trace" cargo pd package -vvv --simulator --lib
    Check that assets of playdate-ui-crank-indicator crate have to be in the produced package, but not 🤷🏻‍♂️.
@boozook boozook added bug Something isn't working cargo About cargo or cargo-playdate assets Assets Build System labels May 31, 2024
@boozook boozook moved this to Todo in Playdate Development May 31, 2024
@boozook boozook mentioned this issue May 31, 2024
Merged
2 tasks
@boozook boozook mentioned this issue Jun 8, 2024
Merged
@boozook
Copy link
Owner Author

boozook commented Jun 10, 2024

#376 fixes this but that is not used in pipeline, just testing and comparing new results with old.

@boozook boozook linked a pull request Jun 15, 2024 that will close this issue
Assets-builder refactoring #376
Merged
@boozook boozook closed this as completed Jun 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Playdate Development Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assets Assets Build System bug Something isn't working cargo About cargo or cargo-playdate
Projects
Playdate Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assets-builder refactoring boozook/playdate
1 participant
@boozook