Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning issue #8582

Open
ThomasWaldmann opened this issue Dec 9, 2024 · 6 comments
Open

versioning issue #8582

ThomasWaldmann opened this issue Dec 9, 2024 · 6 comments

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Dec 9, 2024

vancheese says:

I'm having issues with the version numbers as it appears the forking results in a version which is rejected by version.py module.

(add steps how to reproduce this problem)

Is there a way to override/define the version in the pyproject.toml so I can test the documentation etc using the latest git version?

Originally posted by @vancheese in #8550 (comment)

@vancheese
Copy link

Steps to reproduce

  1. fork borgbackup repo to a personal repo
  2. Checkout repo
  3. enter local repo
  4. virtualenv --python=$(which python3) borg-env
  5. source borg-env/bin/activate
  6. pip install -r requirements.d/development.txt
  7. pip install -r requirements.d/docs.txt
  8. pip install -e .
  9. borg -v

File "/home/andy/Documents/Repos/borg/src/borg/version.py", line 24, in parse_version
raise ValueError("Invalid version string %s" % version)
ValueError: Invalid version string 0.1.dev8904+g84744ac.d20241215

@ThomasWaldmann
Copy link
Member Author

How did you do 1. and 2.?

What does git tag output?

@vancheese
Copy link

vancheese commented Dec 15, 2024

  1. was a Github fork
  2. was a standard git clone

git tag returns nothing

@ThomasWaldmann
Copy link
Member Author

git tag returns nothing

git fetch --tags should fix the issue, then pip install -e . again.

@vancheese
Copy link

Yeah, that fixed everything, sorry about that and thanks

@ThomasWaldmann
Copy link
Member Author

If you like, check our developer docs and maybe add better instructions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants