Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include patterns during backup extraction #1078

Closed
Golddouble opened this issue Oct 15, 2021 · 16 comments
Closed

Include patterns during backup extraction #1078

Golddouble opened this issue Oct 15, 2021 · 16 comments
Labels
status:needs details Needs more details before it can be solved. status:stale This item will be closed soon due to inactivity

Comments

@Golddouble
Copy link

Golddouble commented Oct 15, 2021

During restoring my Backup I got some warnings:

2021-10-15 18:57:01,611 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/history' never matched.
2021-10-15 18:57:01,611 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/elements' never matched.
2021-10-15 18:57:01,612 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/tasks' never matched.
2021-10-15 18:57:01,612 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/collection.ini' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/reports' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/recover' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/subsets' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/registry' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/stats' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/My files/systems/This are my favourite/info' never matched.

Does this just mean, that this folders were empty and so there were no files from this folders to restore?

Thank you.

@m3nu
Copy link
Contributor

m3nu commented Oct 16, 2021

Looks like it's missing a leading /? Which leads to this folder not being found.

@m3nu m3nu added the type:support A question about using vorta label Oct 16, 2021
@Golddouble
Copy link
Author

Golddouble commented Oct 17, 2021

I do not understand. For example in
'home/Golddouble/My files/systems/This are my favourite/elements'
There were files and folders in the archiv, that I have restored. And also I have this folders and archives in my files system after the restore. So it looks as if all has worked as it should work.

Looks like it's missing a leading /? Which leads to this folder not being found.

Where could such a "/" be missing? In my real filesystem or in the archive?

@bastiencyr
Copy link
Collaborator

bastiencyr commented Oct 20, 2021

Every absolute paths start with a '/'
So its not "home/Golddouble/foo" but "/home/Golddouble/foo"

@Golddouble
Copy link
Author

Thank you. I understand now which "/" you mean.

But my archive was big. Here is another example of my Vorta.Log:

2021-10-15 18:56:53,452 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/stats/topicprioritymissed.dat
2021-10-15 18:56:53,452 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/stats/total.dat
2021-10-15 18:56:53,453 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/subsets
2021-10-15 18:56:53,453 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/subsets/last_branch.sub
2021-10-15 18:56:53,454 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/tasks
2021-10-15 18:56:53,454 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/tasks/Tasks.dat
2021-10-15 18:56:53,454 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/temp
2021-10-15 18:57:01,611 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/history' never matched.
2021-10-15 18:57:01,611 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/elements' never matched.
2021-10-15 18:57:01,612 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/tasks' never matched.
2021-10-15 18:57:01,612 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/collection.ini' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/reports' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/recover' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/subsets' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/registry' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/stats' never matched.
2021-10-15 18:57:01,613 - vorta.borg.borg_thread - WARNING - Include pattern 'home/Golddouble/my collection/systems/muda per sado/info' never matched.

Question: It looks like for example according to the line:

2021-10-15 18:56:53,452 - vorta.borg.borg_thread - INFO - home/Golddouble/my collection/systems/Versuche mit xml import/stats/topicprioritymissed.dat

...here is no "/" missing.

But why should in this archive be a "/" missing before the lines with the warning, but not be a "/" missing before the other lines?
They both have the same beginning and the archive was created at the same time.

@bastiencyr
Copy link
Collaborator

bastiencyr commented Oct 20, 2021

Can you post a screenshot of your source folder tab please.

...here is no "/" missing.

The '/' doesnt depend on us. Its how your filesystem of your Operating System (Linux or Mac) is built.

@Golddouble
Copy link
Author

Can you post a screenshot of your source folder tab please.

ksnip_20211020-163441

The '/' doesnt depend on us. Its like your filesystem of your Operating System (Linux or Mac) is built.

It's Linux.

@bastiencyr
Copy link
Collaborator

I cant help you more. Be sure that your folders are backup.

@bastiencyr bastiencyr added status:needs details Needs more details before it can be solved. and removed type:support A question about using vorta labels Oct 22, 2021
@m3nu
Copy link
Contributor

m3nu commented Oct 24, 2021

I use this on macOS and works from what I see. Is this still an issue? If yes, have you tried testing your excludes with Borg directly and compare?

Actually I'm planning to redo this tab at some point and add excludes in a more structured way. Free text field isn't great and can cause errors. See #907 to weigh in, add more ideas or even add a PR.

@stale
Copy link

stale bot commented Dec 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale This item will be closed soon due to inactivity label Dec 23, 2021
@ghost
Copy link

ghost commented Dec 30, 2021

Same problem here on Fedora 35 with Vorta 0.8.2
The path is missing the leading "/"
Only difference is that it won't come up as warning in the log, instead it seems to fail silently

Sometimes I feel stupid after reading what I wrote a few days prior

@stale stale bot removed the status:stale This item will be closed soon due to inactivity label Dec 30, 2021
@m3nu
Copy link
Contributor

m3nu commented Dec 30, 2021

Borg saves all paths as relative paths. So home/bob etc.

The OP's issue happens during extraction. The way extraction works in Vorta is that you get a tree of all paths and can check them one-by-one.

This isn't perfect, since we can't account for nesting very well.

If there is an issue with this extraction feature, we would want to see the logs from Misc > Log which would have the actual Borg command which is run.

@m3nu m3nu changed the title Waring Include pattern [...] never matched Include patterns during backup extraction Dec 30, 2021
@Golddouble
Copy link
Author

Golddouble commented Jan 20, 2022

If there is an issue with this extraction feature, we would want to see the logs from Misc > Log which would have the actual Borg command which is run.

OK. Here is the log-file:
/deleted/

@stale
Copy link

stale bot commented Mar 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale This item will be closed soon due to inactivity label Mar 22, 2022
@real-yfprojects
Copy link
Collaborator

The warnings you are getting are not an error, neither an issue. Actually, everything should be working fine and all files you wanted to extract should have been extracted. The warning is issued by borg and has the following reason:

When starting the extraction, vorta called borg with the archive to extract:

2022-01-20 14:56:19,425 - vorta.borg.borg_thread - INFO - Running command /usr/bin/borg extract --list --info --log-json /media/Golddouble/Seagate_2TB_ext4/Linux_Home/Vorta/MX_19_ganzes_Home_ohne_VMs::202201172057--- [...]

and paths to the files to extract:

[...] home/Golddouble/Supermemo Collections/systems home/Golddouble/Supermemo Collections/systems/ABC of SuperMemo 18.KNO [...]

Here you can see that borg is told to extract the systems directory and afterwards a file inside that directory. Borg therefore can't extract the file inside the folder after extracting the folder itself and issues the warning.
Vorta passes the folder and the file to borg because you ticked the checkboxes for both of them.

@stale stale bot removed the status:stale This item will be closed soon due to inactivity label Mar 22, 2022
@Golddouble
Copy link
Author

Thank you @real-yfprojects

@stale
Copy link

stale bot commented May 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale This item will be closed soon due to inactivity label May 30, 2022
@stale stale bot closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs details Needs more details before it can be solved. status:stale This item will be closed soon due to inactivity
Projects
None yet
Development

No branches or pull requests

4 participants