Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined exclusion patterns have no effect #1415

Closed
unfa opened this issue Sep 2, 2022 · 7 comments
Closed

User-defined exclusion patterns have no effect #1415

unfa opened this issue Sep 2, 2022 · 7 comments
Labels
status:stale This item will be closed soon due to inactivity type:question

Comments

@unfa
Copy link

unfa commented Sep 2, 2022

Describe the bug
I have specified exclusion patterns to avoid backing up unnecessary data, but borg seems to completely ignore them. I have consulted borg manual to make sure the format is correct.

Am I doing something wrong or is this a bug?

My exclusion patterns:

/data/Temp/**
/data/Disposable/**
/home/unfa/mountpoint/**
**/.cache/**
**/Olive/mediacache/**
**/hiberfil.sys
**/swapfile.sys
**/pagefile.sys
/mnt/windows/Users/unfa/[...]
**/SteamLibrary/**

To Reproduce

  1. Define an exclusion pattern
  2. Run backup
  3. Watch as the excluded files are still backed up

Environment (please complete the following information):

  • OS: Arch Linux
  • Vorta version: 0.8.7
  • Borg version: 1.2.2
  • Installed from: AUR vorta-git PKGBUILD

Vorta and Borg versions can be found in Main Window > Misc Tab.

@real-yfprojects
Copy link
Collaborator

I think you have to replace /** in your patterns by /**/*.

@m3nu
Copy link
Contributor

m3nu commented Sep 3, 2022

You're passing sh-style patterns, when the default is fn-style. So you need to either prefix with sh: or change to fn-style.

Borg docs have more (also linked in Vorta): https://borgbackup.readthedocs.io/en/stable/usage/help.html#borg-help-patterns.

@unfa
Copy link
Author

unfa commented Sep 3, 2022

So should I prefix every line in my exclusions with sh: ?
Like sh:/data/Temp/** ?

@real-yfprojects
Copy link
Collaborator

So should I prefix every line in my exclusions with sh: ?
Like sh:/data/Temp/** ?

Yes, though I am pretty sure my point applies too.

@unfa
Copy link
Author

unfa commented Sep 3, 2022

So should I prefix every line in my exclusions with sh: ?
Like sh:/data/Temp/** ?

Yes, though I am pretty sure my point applies too.

Thanks, I will test this.

I wonder if Vorta could help users verify if these things are properly formatted, do some basic syntax checks or stuff?
I tried to follow the examples but ended up with something that wasn't valid.

@m3nu
Copy link
Contributor

m3nu commented Sep 4, 2022

I wonder if Vorta could help users verify if these things are properly formatted, do some basic syntax checks or stuff? I tried to follow the examples but ended up with something that wasn't valid.

Already planned for a while. See #907

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale This item will be closed soon due to inactivity label Nov 9, 2022
@stale stale bot closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale This item will be closed soon due to inactivity type:question
Projects
None yet
Development

No branches or pull requests

3 participants