Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify exclude vs patterns setting in Exclude UI #2104

Open
m3nu opened this issue Oct 20, 2024 · 1 comment
Open

Clarify exclude vs patterns setting in Exclude UI #2104

m3nu opened this issue Oct 20, 2024 · 1 comment
Labels
type:enhancement Improvement of an existing function type:task A TODO

Comments

@m3nu
Copy link
Contributor

m3nu commented Oct 20, 2024

Thank you for the flexible interface for "exclude"!

There is one point that is quite confusing in borg - and since Vorta is referring to the borg documentation, this applies to Vorta too.

In borg there are two distinct sets of options which can be used for excludes:
--exclude and --exclude-from
AND
--pattern or --patterns-from

Only the second set of options uses the term "pattern" in its name.
To cite the borg documentation:

A more general and easier to use way to define filename matching patterns exists with the --pattern and --patterns-from options. Using these, one may specify the backup roots, default pattern styles and patterns for inclusion and exclusion.

If I understand correctly, currently, Vorta only supports --exclude. This should be stressed in the user interface (which links to the borg documentation) to reduce the confusion.

Originally posted by @goebbe in #907 (comment)

@goebbe
Copy link
Contributor

goebbe commented Oct 28, 2024

The following screenshot shows the "exclude dialog" in Vorta 0.9.1.

Screenshot from 2024-10-28 08-52-56

Perhaps, the following would be less confusing:

Title: Exclude files and folders
Dialog text:
Exclude files and folders from the backup. Exclude uses file name pattern matching (fnmatch) by default, see documentation. To add multiple patterns at once, use the "Raw" tab

@m3nu m3nu added type:enhancement Improvement of an existing function type:task A TODO labels Oct 28, 2024
@m3nu m3nu added this to the v0.10 (Next major release) milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvement of an existing function type:task A TODO
Projects
None yet
Development

No branches or pull requests

2 participants