Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Warning #20

Closed
echo-bravo-yahoo opened this issue Jan 18, 2017 · 2 comments
Closed

Deprecation Warning #20

echo-bravo-yahoo opened this issue Jan 18, 2017 · 2 comments

Comments

@echo-bravo-yahoo
Copy link

Using n_@1.4.4 and node@7.4.0, (almost) any input results in this warning being printed:

DeprecationWarning: Calling an asynchronous function without callback is deprecated.
@borisdiakur
Copy link
Owner

borisdiakur commented Jan 19, 2017 •
edited
Loading

The repl.history module, which n_ uses to persist its repl history, writes to the file without providing a callback: https://github.com/tmpvar/repl.history/blob/master/index.js#L15

I will report it there, probably send a PR. This should be resolved quickly.

tmpvar/repl.history#10

@borisdiakur
Copy link
Owner

The PR has been accepted and a new version of repl.history has been published.
tmpvar/repl.history#11 (comment)
You can now reinstall n_ and the warning will be gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borisdiakur @echo-bravo-yahoo