Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture standard error from curl shell command #18

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

jaydeesimon
Copy link
Contributor

If there is a nonzero exit status code from the curl shell command, there is an error message written to standard error. This pull request captures the error message, if one exists, and adds a key for it in the resulting response object.

@borkdude
Copy link
Collaborator

@jaydeesimon I made a couple of changes in 57ffee2.

  • Rename the key to :err, same as clojure.java.shell/sh, does that make sense?
  • Pass the stream if the request if asking for a stream with :as :stream. Else slurping the error output blocks.
  • Added documentation

@borkdude borkdude merged commit 8a53b65 into babashka:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants