Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document light_* colors? #124

Closed
joshorr opened this issue Sep 29, 2022 · 4 comments
Closed

Document light_* colors? #124

joshorr opened this issue Sep 29, 2022 · 4 comments

Comments

@joshorr
Copy link

joshorr commented Sep 29, 2022

I was trying to figure out how to get the bright colors that Pycharm terminal supports. Took my some time before I released there were undocumented colors, the light_* colors.

I could adjust the documentation for you if you want to added the light_* colors to the README.md, or did you want to do that, or did you want to just leave it as-is?

Figured I would open this up, as it would have saved me a bunch of time if they were in the list of colors.

@borntyping
Copy link
Owner

A PR to adjust the documentation would be appreciated!

I suspect the reason I never properly documented the light_ foreground and background colours is that they aren't supported by all terminals. They're also incorrectly named, and really should be called bright. These colours were added recently and copied the names used by the colorama library: #87.

@joshorr
Copy link
Author

joshorr commented Sep 30, 2022

Yes, pycharm uses the term Bright, and the non-bright white is grey.

Probably fine to keep them as-is so it won’t break anything.

I’ll try to get a doc change pr up over the weekend.

@joshorr
Copy link
Author

joshorr commented Nov 2, 2022

Sorry, have not gotten to this yet. I'll try to do it by end of week.

@borntyping
Copy link
Owner

No rush - this library's been around a while, fixes like this aren't urgent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants