Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error codes and message when sebak has problems #724

Open
outsideris opened this issue Nov 15, 2018 · 1 comment
Open

Better error codes and message when sebak has problems #724

outsideris opened this issue Nov 15, 2018 · 1 comment
Assignees
@kfangw
Labels
API Proposal

Comments

@outsideris
Copy link
Contributor

When sebak has some problems like the consensus is failed or doesn't work, it should return HTTP 500 status code and properly message.
For example, when sebak can not make consensus and can not make new block, it still return 400 error to client like sebak is ok.
I also think it is hard to detect consensus problems but it is helpful for clients to show error messages properly.
@kfangw
Copy link
Contributor

kfangw commented Nov 21, 2018

#759 may solve this issue.
But If I have a chance, I dig into it.

@kfangw kfangw self-assigned this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfangw kfangw

Labels
API Proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anarcher @outsideris @kfangw