Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSS-02C: Inactive EIPs Referenced #303

Closed
zajck opened this issue Feb 2, 2022 · 0 comments · Fixed by #307
Closed

VSS-02C: Inactive EIPs Referenced #303

zajck opened this issue Feb 2, 2022 · 0 comments · Fixed by #307

Comments

@zajck
Copy link
Member

zajck commented Feb 2, 2022

VSS-02C: Inactive EIPs Referenced

Type Severity Location
Code Style Informational VoucherSets.sol:L13

Description:

The comment linked references deprecated and / or inactive EIPs that should not be referred to if not implemented.

Example:

//preparing for ERC-1066, ERC-1444, EIP-838

Recommendation:

We advise this comment to be revised in a bit more depth to ensure that it illustrates its purpose to the reader. For example, EIP-838 will most likely never be implemented given that a different methodology for errors has been introduced in the latest version of Solidity using the error keyword.

@zajck zajck changed the title Inactive EIPs Referenced VSS-02C: Inactive EIPs Referenced Feb 2, 2022
@zajck zajck closed this as completed in #307 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant