Testing GH change fetching #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when using threaded view Symptom ======= When using roundcube with mailboxes with over 60k messages, list view was way faster than viewing in threaded view. Mailbox index view timing: ~360 ms Mailbox threaded view timing: ~800 ms Resolution ========== Use native PHP array manipulation functions instead of rolling custom string data reversal implementation using strpos() and substr() in a 'while' loop. This optimization is already present in index view handler, but was missing from threaded view. Results after optimization ========================== Both average out around ~360 ms response time.
…g-faster Make rcube_result_thread::revert() faster
bostjan
added a commit
that referenced
this pull request
Apr 14, 2016
…_insert' actual search and result data Reason: In order to enable development of sophisticated autocomplete algorithms, they will need to process all the data relevant to autocomplete - what was the search string and which result was the correct one. Example to illustrate the need: Say we are talking about these two people of interest, who are in the address book, among others: - person 1: Bostjan Skufca <bostjan@a2o.si> - person 2: Bostjan SkuBIC <bostjan@otherdomain.com> Our user is used to think about the first person by the first name, "Bostjan", as he is an old friend. The second one is a colleague at work where people call themselves mostly by surnames, "Skubic" in this case. Without this data provided to 'autocomplete_insert', there is no way for RC to learn that when our user enters "bos" in the To: field he thinks about person #1 (Bostjan SkuFCA), and when he starts typing "sku" he means person roundcube#2 (Bostjan SkuBIC).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.