Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump urllib3 requirement to v2 #2982

Closed
2 tasks
sodul opened this issue Jul 13, 2023 · 1 comment
Closed
2 tasks

Bump urllib3 requirement to v2 #2982

sodul opened this issue Jul 13, 2023 · 1 comment
Assignees
@RyanFitzSimmonsAK
Labels
duplicate This issue is a duplicate. feature-request This issue requests a feature. p3 This is a minor priority issue

Comments

@sodul
Copy link

sodul commented Jul 13, 2023

Describe the feature

botocore requires urllib3<1.27 preventing the installation of urllib3 v2.

Use Case

We want to work with boto and urllib3 v2.

Proposed Solution

Unless there is a runtime dependency on the deprecated methods in urllib3 v2 that requirement should either be updated or removed.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

boto3==1.28.3, botocore==1.31.3

Environment details (OS name and version, etc.)

macOS 13.4.1 (c)
@sodul sodul added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Jul 13, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Jul 13, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK added investigating This issue is being investigated and/or work is in progress to resolve the issue. dependencies This issue is a problem in a dependency. p3 This is a minor priority issue duplicate This issue is a duplicate. and removed needs-triage This issue or PR still needs to be triaged. dependencies This issue is a problem in a dependency. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 13, 2023
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @sodul, thanks for reaching out. This request has been made several times in the past, and the team has made a reply in another issue.

Hi @epicserve, thanks for reaching out. The pin is currently intentional while we wait for the major version bump to stabilize. We intend to move the pin shortly after Requests does to ensure we're not negatively impacting users.

We'll keep this issue updated and feel free to follow along in psf/requests#6432 as well if you like.

Any updates about this pin will be in the tracking issue that I linked. Hope that helps!

@RyanFitzSimmonsAK RyanFitzSimmonsAK closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanFitzSimmonsAK RyanFitzSimmonsAK

Labels
duplicate This issue is a duplicate. feature-request This issue requests a feature. p3 This is a minor priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sodul @RyanFitzSimmonsAK