Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schnauzer templates instead of pluto #1845

Closed
tjkirch opened this issue Nov 30, 2021 · 4 comments
Closed

Schnauzer templates instead of pluto #1845

tjkirch opened this issue Nov 30, 2021 · 4 comments
Labels
area/settings Issues related to our settings handling status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request

Comments

@tjkirch
Copy link
Contributor

tjkirch commented Nov 30, 2021

We migrated from pluto to schnauzer to generate pod-infra-container-image:

/// We moved from using pluto to schnauzer for generating the pause container image URL, since it
/// lets us reuse the existing region and arch settings, improving reliability and allowing for
/// testing new regions through settings overrides.

The same may well be true of other uses of pluto. In addition, it would be nice to have one less tool and to standardize on templated settings through schnauzer helpers.

This could help out-of-tree build efforts since we wouldn't need a tool like pluto to be specialized or understand any variant specifics; using schnauzer helpers instead means their use is determined by included settings and their templates.

@tjkirch
Copy link
Contributor Author

tjkirch commented Nov 30, 2021

Note: this may benefit from #1585 (dependencies between settings).

@zmrow
Copy link
Contributor

zmrow commented Dec 1, 2021

I'm wondering about the "debug-ability" of having these types of things in template helpers. A service like pluto has the advantage of its output going directly to the journal. Template helpers don't have this luxury.

@tjkirch
Copy link
Contributor Author

tjkirch commented Dec 1, 2021

I'm wondering about the "debug-ability" of having these types of things in template helpers. A service like pluto has the advantage of its output going directly to the journal. Template helpers don't have this luxury.

If we fix:

// FIXME where to send output?
we should be able to get their logs.

@etungsten etungsten added area/kubernetes K8s including EKS, EKS-A, and including VMW status/needs-triage Pending triage or re-evaluation labels Nov 4, 2022
@stmcginnis stmcginnis added type/enhancement New feature or request area/settings Issues related to our settings handling status/icebox Things we think would be nice but are not prioritized and removed area/kubernetes K8s including EKS, EKS-A, and including VMW status/needs-triage Pending triage or re-evaluation labels Mar 9, 2023
@webern
Copy link
Contributor

webern commented Mar 22, 2024

Closing as a historical relic that doesn't have a lot of bearing on Settings 2.0

@webern webern closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/settings Issues related to our settings handling status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants