Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline registry mirror configuration is deprecated in containerd #1963

Open
alex-berger opened this issue Feb 18, 2022 · 7 comments
Open

Inline registry mirror configuration is deprecated in containerd #1963

alex-berger opened this issue Feb 18, 2022 · 7 comments
Labels
area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request

Comments

@alex-berger
Copy link

What I'd like:

Inline registry mirror configuration as used by bottlerocket is deprecated since containerd version 1.5.0 and might be removed in containerd version 1.7.

Bottlerocket should be update to use the new approach to configure the image registries for containerd, as outlined in


Setting config_path instead of inlining the mirror configuartion,

[plugins."io.containerd.grpc.v1.cri".registry]
   config_path = "/etc/containerd/certs.d"

and generating the corresponding directory structure and files

$ tree /etc/containerd/certs.d
/etc/containerd/certs.d
└── docker.io
    └── hosts.toml

$ cat /etc/containerd/certs.d/docker.io/hosts.toml
server = "https://docker.io"

[host."https://registry-1.docker.io"]
  capabilities = ["pull", "resolve"]
@etungsten etungsten added area/core Issues core to the OS (variant independent) priority/p0 type/enhancement New feature or request labels Feb 18, 2022
@kdaula kdaula added this to v1.8.0 Mar 7, 2022
@kdaula kdaula modified the milestones: 1.8.0, 1.9.0 May 3, 2022
@kdaula kdaula removed this from v1.8.0 May 3, 2022
@cbgbt cbgbt added this to 1.9.0 Jun 1, 2022
@cbgbt cbgbt self-assigned this Jun 1, 2022
@cbgbt cbgbt modified the milestones: 1.9.0, 1.10.0 Jun 22, 2022
@cbgbt cbgbt modified the milestones: 1.10.0, 1.8.0, 1.9.0 Jun 22, 2022
@cbgbt cbgbt removed this from 1.9.0 Jun 22, 2022
@cbgbt cbgbt modified the milestones: 1.9.0, 1.10.0 Jun 22, 2022
@kdaula kdaula modified the milestones: 1.10.0, next Aug 31, 2022
@kdaula kdaula assigned etungsten and unassigned etungsten Sep 14, 2022
@stmcginnis stmcginnis added the status/needs-triage Pending triage or re-evaluation label Dec 1, 2022
@stmcginnis stmcginnis removed this from the next milestone Mar 2, 2023
@stmcginnis stmcginnis added status/icebox Things we think would be nice but are not prioritized and removed status/needs-triage Pending triage or re-evaluation labels Mar 9, 2023
@phillebaba
Copy link

I think that this feature would be good to solve as there are a lot of other feature requests which would be solved by just updating the mirror configuration. Instead of having to expose every single parameter users would be able to write their own mirror configuration files which would be placed in the correct file path.

@vyaghras vyaghras mentioned this issue Oct 17, 2023
14 tasks
@dims
Copy link

dims commented Nov 15, 2023

@empath-nirvana
Copy link

Is there any update on this? I'd really like to install "spegel" and can't because of this issue.

spegel-org/spegel#47

@danielloader
Copy link

AND 2.0 beta

https://github.com/containerd/containerd/blob/v2.0.0-beta.0/pkg/cri/config/config.go#L189-L190

What if it's only hanging about because people keep using it and the maintainers are being overly cautious because people haven't stopped using it?

@sumeet-zuora
Copy link

Any update on this? is Bottlerocket going to support this

@naanselmo
Copy link

Appears to have been slated for removal in containerd 2.1, pushed back from its previous targeted removal of 2.0.

https://github.com/containerd/containerd/blob/e514bae935a24e78c1e66ae4d609040b9f14a8e4/internal/cri/config/config.go#L221-L225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests