fix(ngResource): Remove request body from $delete

bourey · bourey · commit 3244f03c2144 · 2013-10-04T12:41:16.000-07:00
Prevent the obj.$delete instance method from sending the resource as the request body. This commit uses the existing hasBody boolean to only set httpConfig.data for methods which should have a request body. Closes angular#4280
diff --git a/src/ngResource/resource.js b/src/ngResource/resource.js
@@ -466,7 +466,7 @@ angular.module('ngResource', ['ng']).
             }
           });
 
-          httpConfig.data = data;
+          if (hasBody) httpConfig.data = data;
           route.setUrlParams(httpConfig, extend({}, extractParams(data, action.params || {}), params), action.url);
 
           var promise = $http(httpConfig).then(function(response) {

Original file line number	Diff line number	Diff line change
`@@ -466,7 +466,7 @@ angular.module('ngResource', ['ng']).`
`466`	`466`	`}`
`467`	`467`	`});`
`468`	`468`
`469`		`- httpConfig.data = data;`
	`469`	`+ if (hasBody) httpConfig.data = data;`
`470`	`470`	`route.setUrlParams(httpConfig, extend({}, extractParams(data, action.params \|\| {}), params), action.url);`
`471`	`471`
`472`	`472`	`var promise = $http(httpConfig).then(function(response) {`