Form groups of about 3 people and review PubPrice.cs in Pub. Which code smells can you find? Refactor to remove smell(s). There is a small test suite that will help you along the way. Introduce more tests if you need them.
You will learn to:
- Identify bad code
- Fix code smells
- Refactor with tests
- An IDE of common choice. Ex. Visual Studio or Visual Studio Code
- Install dotnet core >= 1.3 https://dotnet.microsoft.com/download
✏️ Open command prompt with path source\Pub and run dotnet build, dotnet test, dotnet run --project Pub/Pub.csproj
❓ What does this code do? Before you start changing the code, understand what the code does.
❓ What is wrong with the code? There are naming issues, magical numbers, bad structure and more.
The main part of this exercise is to refactor the code. You'll get to do much of this on your own, but here are some fairly small tasks to start with:
✏️ Fix all the magical numbers.
✏️ Rename existing functions so their names reflect what they do.
✏️ Remove bad comments.
✏️ Make functions where appropriate if there are clear bits of the code that are independent of the rest.
✏️ Create classes to solve the problems in the OOP way.
From now on you're on your own. There are many ways to refactor this code and not necessarily one correct one. It's useful to discuss whether you see any code that should be separated into and what each class should do. Can any of the code structures you've learned about make this code easier to read and easier to maintain? If you add more drinks to the menu, how can you make the code support this in the best way possible?