fix(a11y): wrong focus selection on toggleFullscreen method #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
reviewed
Sep 22, 2021
|
Also, you may need to rename your PR to reflect the commit naming convention |
matiaslionel
changed the title
matiaslionel
changed the title
jstoffan
reviewed
Sep 22, 2021
fixed! Thanks. |
matiaslionel
changed the title
jstoffan
previously approved these changes
Sep 24, 2021
jstoffan
approved these changes
Sep 24, 2021
|
Are we ready to merge this PR? |
ConradJChan
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the fullscreen is toggled the focus should go back to the fullscreen toggle button located on toolbar.