feat: Add support for modifiable retention policies & enable deleting retention policy assignment #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… retention policy assignment
mwwoda
reviewed
Nov 2, 2022
Comment on lines
+61
to
+64
| options: [ | ||
| 'modifiable', | ||
| 'non_modifiable' | ||
| ] |
There was a problem hiding this comment.
Can you elaborate a bit on the reason for including the option to set modifiable as string? I thought this was done to allow new values without changing the code in the future (as it cannot be done with boolean flags), but I see that we are still limiting the possible options.
There was a problem hiding this comment.
I added this to be compatible with update method, when we can only update type to non-modifiable
mwwoda
approved these changes
Nov 2, 2022
congminh1254
pushed a commit
that referenced
this pull request
Jan 31, 2024
… retention policy assignment (#420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.