Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to send reaction #110

Open
cs-t1 opened this issue Nov 8, 2021 · 2 comments
Open

Unable to send reaction #110

cs-t1 opened this issue Nov 8, 2021 · 2 comments

Comments

@cs-t1
Copy link
Contributor

cs-t1 commented Nov 8, 2021

On both the current master branch, the reaction feature seems to be broken.

When sending a reaction, it correctly appears locally but seem not to get sent as it does not appear on any other device.

After experimenting a bit with the code, it seems that adding

timestamp: Some(timestamp),

in the message

gurk-rs/src/signal.rs

Lines 168 to 176 in eda8557

let mut data_message = DataMessage {
reaction: Some(Reaction {
emoji: Some(emoji.clone()),
remove: Some(remove),
target_author_uuid: Some(target_author_uuid.to_string()),
target_sent_timestamp: Some(target_sent_timestamp),
}),
..Default::default()
};

solves the issue.

@cs-t1
Copy link
Contributor Author

cs-t1 commented Nov 16, 2021

After some more testing, it appears this problems occurs whenever I'm connected to an unstable network.

This raises another question : we currently do not support sending/caching messages when no connection is available. Would it be possible to implement this?

@boxdot
Copy link
Owner

boxdot commented Nov 14, 2024

Fixed in #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants