-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lc thinks MIT is JSON if there are 2 copyright lines #36
Comments
MIT and JSON. The bane of my existence. Annoyingly on the failing case it is so close to being correct as well with the generic method of checking.
Going to add in a special case specifically for this situation. I believe that's how other tools handle this situation anyway. Since the licenses shouldn't change rather there will be a new one rather than the old one being updated this isn't the worst option in the world. |
Waiting for CI to process, and if all good will be merged in. Hope you don't mind me using the emails in the above example as test cases. If you do let me know and ill change them. |
Not sure if you are building from source, but if you grab the latest and install it the results should be correct for your case now. Ill package it up into an official release now. |
On Thu, Mar 08, 2018 at 09:28:06PM +0000, Ben Boyter wrote:
Not sure if you are building from source, but if you grab the latest and
install it the results should be correct for your case now. Ill package it up
into an official release now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.*
Thanks, i'm getting the binary package from Void Linux, i am pushing to using SPDX titles for our license= keys in the package templates. we have a few thousand packages that wrongly indicate `BSD` so i'm using lc to correctly identify the license.
|
No problem ill push it out now. |
After looking at the above a little more closely they look more like Going to leave it as MIT-feh as one of the signals used to determine the difference is that MIT starts with |
with 2 copyright lines
with 1 copyright line
LICENSE file
The text was updated successfully, but these errors were encountered: