Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lc thinks MIT is JSON if there are 2 copyright lines #36

Closed
maxice8 opened this issue Mar 8, 2018 · 7 comments
Closed

lc thinks MIT is JSON if there are 2 copyright lines #36

maxice8 opened this issue Mar 8, 2018 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@maxice8
Copy link

maxice8 commented Mar 8, 2018

with 2 copyright lines

File     License  Confidence  Size
masterdir/builddir/libmaa-1.4.2/doc/  LICENSE  JSON     92.85%      1.1K

with 1 copyright line

File     License  Confidence  Size
masterdir/builddir/libmaa-1.4.2/doc/  LICENSE  MIT      94.29%      1.1K

LICENSE file

Copyright (c) 1995-2002 Rik Faith <rikfaith@gmail.com>
Copyright (c) 2002-2018 Aleksey Cheusov <vle@gmx.net>

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
@boyter
Copy link
Owner

boyter commented Mar 8, 2018

MIT and JSON. The bane of my existence. Annoyingly on the failing case it is so close to being correct as well with the generic method of checking.

{JSON 0.928547293335935} {MIT 0.9224754899801437}

Going to add in a special case specifically for this situation. I believe that's how other tools handle this situation anyway. Since the licenses shouldn't change rather there will be a new one rather than the old one being updated this isn't the worst option in the world.

@boyter boyter self-assigned this Mar 8, 2018
@boyter boyter added the bug Something isn't working label Mar 8, 2018
@boyter
Copy link
Owner

boyter commented Mar 8, 2018

#37

Waiting for CI to process, and if all good will be merged in. Hope you don't mind me using the emails in the above example as test cases. If you do let me know and ill change them.

@boyter
Copy link
Owner

boyter commented Mar 8, 2018

Not sure if you are building from source, but if you grab the latest and install it the results should be correct for your case now. Ill package it up into an official release now.

@maxice8
Copy link
Author

maxice8 commented Mar 8, 2018 via email

@boyter
Copy link
Owner

boyter commented Mar 8, 2018

No problem ill push it out now.

@boyter
Copy link
Owner

boyter commented Mar 8, 2018

@boyter boyter closed this as completed Mar 8, 2018
@boyter
Copy link
Owner

boyter commented May 7, 2018

After looking at the above a little more closely they look more like MIT-feh than MIT which is what they are being picked up as in the application with the new tweaks.

Going to leave it as MIT-feh as one of the signals used to determine the difference is that MIT starts with The MIT License and MIT-feh does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants