You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the init method of PolylineSet is doing a fair bit of work and could be refactored. In other resqpy classes, we've tried separate out any alternative constructor options as separate class methods. An example is resqpy.well.DeviationSurvey.from_data_frame . This helps keep the init method simple.
I would suggest making class methods e.g.PolylineSet.from_irap_file() and PolylineSet.from_charisma_file()
I think the init method of
PolylineSet
is doing a fair bit of work and could be refactored. In other resqpy classes, we've tried separate out any alternative constructor options as separate class methods. An example isresqpy.well.DeviationSurvey.from_data_frame
. This helps keep the init method simple.I would suggest making class methods e.g.
PolylineSet.from_irap_file()
andPolylineSet.from_charisma_file()
Originally posted by @connortann in #164 (comment)
The text was updated successfully, but these errors were encountered: