Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class constructor methods in PolylineSet #167

Open
Tracked by #278
connortann opened this issue Aug 4, 2021 · 1 comment
Open
Tracked by #278

Use class constructor methods in PolylineSet #167

connortann opened this issue Aug 4, 2021 · 1 comment
Labels
refactor Restructure or simplification

Comments

@connortann
Copy link
Collaborator

I think the init method of PolylineSet is doing a fair bit of work and could be refactored. In other resqpy classes, we've tried separate out any alternative constructor options as separate class methods. An example is resqpy.well.DeviationSurvey.from_data_frame . This helps keep the init method simple.

I would suggest making class methods e.g.PolylineSet.from_irap_file() and PolylineSet.from_charisma_file()

Originally posted by @connortann in #164 (comment)

@andy-beer
Copy link
Contributor

Issue #278 is a superset of this issue.

@cflynn3 cflynn3 added this to the Future Enhancements milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructure or simplification
Projects
None yet
Development

No branches or pull requests

3 participants