Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pre-commit hooks #394

Open
connortann opened this issue Jan 21, 2022 · 0 comments
Open

Enable pre-commit hooks #394

connortann opened this issue Jan 21, 2022 · 0 comments

Comments

@connortann
Copy link
Collaborator

Plenty of PRs have failed jobs due to code formatting and flake8 errors, which suggests that some time is being wasted by devs having to run these tools manually.

We could use the pre-commit python package as a developer dependency, and add a .pre-commit-config.yaml file together with some instructions in the contributor guide to install.

This would mean yapf is run locally automatically on relevant files before each commit is made, so devs can spend their time on more important things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant