Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: delete file while viewing / playing #76

Closed
knguyen0105 opened this issue Jun 10, 2019 · 11 comments
Closed

[Suggestion]: delete file while viewing / playing #76

knguyen0105 opened this issue Jun 10, 2019 · 11 comments
Labels
enhancement extension Features that won't go to the main app, but should be possible to implement them as extension

Comments

@knguyen0105
Copy link

At the moment, the software only support viewing images/videos. Sometimes I only need to keep a few images or videos in a whole downloaded albums / collections to save space on my server.

I'd love to be able to delete an image / video (or a folder) while browsing.

@bpatrik
Copy link
Owner

bpatrik commented Jun 10, 2019

Hi,

Thank you for the suggestion. The aim of this app is to provide a directory-first photo gallery website (i.e., the phosoes should be rendered as they are, without modification). I would like to keep this approach.
Unfortunately deleting photos does not fit into this approach, so I do not plan to add such a feature. Sorry.

Best,
Patrik

@bpatrik
Copy link
Owner

bpatrik commented Jun 26, 2019

I'm closing this due to inactivity

@bpatrik bpatrik closed this as completed Jun 26, 2019
@flesser
Copy link

flesser commented Jul 13, 2019

I really like the read-only and directory-first approach of PiGallery2, which is what makes it much better suited for light-weight installations than e.g. Lychee (which seems to use its own cryptic directory structure, making it hard to work with the images from outside the app).

My personal use case for PiGallery2 is an installation on a Raspi Zero W, which I use to backup my Camera's SD card while travelling (and syncing them back home to my Nextcloud server whenever there's free Wifi available).
With PiGallery2, I can comfortably watch the pictures from the Pi's SD card in my smartphone browser.

However, I also would like some option to delete photos before syncing.

One solution I could imagine -- while keeping PiGallery2's read-only approach -- would be to support flagging Images for deletion only in PiGallery2's database. Or more generally: allow some kind of tagging/flagging (#38).

Another script in the background (not part of PiGallery2) could then access the database and e.g. delete all images that are tagged/flagged in a certain way.

In that way, PiGallery2 core could keep its approach of not altering the images themselves while still allowing more advanced (admin) users to have some kind of image deletion/altering/whatevering options based on user input from the browser.

@bpatrik
Copy link
Owner

bpatrik commented Jul 14, 2019

Hi
In the (distant) future I'll probably make some plug-in feature to the app that would allow adding small features without touching the core of the app. I can see such a deletion feature possible then.
Currently I would not like to add such a feature to the app, as it is not in alignment with the main 'vision' of the app.

Also, it is an open source project, feel free to alter for your taste :)

@flesser
Copy link

flesser commented Jul 15, 2019

Here's my Work in Progress (and mostly quick&dirty) fork with support for trashing images/videos while playing, similar to what the OP @knguyen0105 asked for:
https://github.com/flesser/pigallery2/tree/trashsupport

Basically, once you enable the feature in config.json (Client.Trash.enabled), it shows an additional "Trash" button in the Lightbox (also listening to the Del key).

Trashing files is implemented server-side by moving them into a new subdirectory (Client.Trash.trashFolderName, defaults to _pigallery2_trash) inside each album, which can then be deleted manually on the server. (No Gui support for that yet).

Images can be restored by "trashing" them from the trash folder. In that case, they just get moved back one dir up into the original album.

It's all not really field-tested yet, use at your own risk!

@bpatrik
Copy link
Owner

bpatrik commented Jul 18, 2019

Hi.

Thank you!
As I mentioned, I don't feel this to be in the path of the app, but I'll keep this in mind, when I prepare the plug-in method for the app.

Patrik

@bpatrik bpatrik reopened this Jul 18, 2019
@bpatrik bpatrik added extension Features that won't go to the main app, but should be possible to implement them as extension enhancement labels Jul 18, 2019
@palitu
Copy link

palitu commented Jul 19, 2019

I think that this is something that i would like. I'll tell you how i use PIG.

I dump ALL myp hotos into {YEAR} / {xx MONTH} directories. It is from my camera, or our phones. It doesn't matter. They all go into those folders. From there, i use DigiKam to add tags/captions to the photos.

This allows me to generate "logical albums" using tags (which PIG does a good job of displaying) as well as view all the photos that have been taken by the month.

There is a lot of crap in my bulk uploads, and it would be good to be able to delete them where ever i am, whether i am using DigiKam, or on the net at work. Same goes for adding tags to photos.

I would love a limited set of functionality that would allow me to edit the files via PIG. Also a list of tags from the DB would be awesome too!

@jezikk82
Copy link

Any change that the delete function will be implemented ? (even @flesser approach is enough).
PiGallery is running on mobile Rpi. I have similar use case that all my pic from DSLR and phones are auto sync to "yy.mm.dd - event" structure and for first, quick preview I use pigallery. On bigger screen (often TV in hotel) I'd like to be able to remove bad shots.

@bpatrik
Copy link
Owner

bpatrik commented May 31, 2021

No really. I was thinking about putting this to some kind of addon, but the more I think of that the less I see the solution for creating addons.

Generally I do not want so see any gallery modifying feature on my personal instance. Making #310 would it make possible to separate it.
Not sure if I will have time for this in the near future.

I updated the README.md to reflect this state of the app.

@bpatrik
Copy link
Owner

bpatrik commented Dec 16, 2022

Closing this as it goes against he current philosophy of the app:
😥 Its simple. Shows what you have that's it. No gallery changes (photo delete, rotate, enhance, tag, organize, etc), your gallery folder is read-only.

@bpatrik bpatrik closed this as completed Dec 16, 2022
@pepa65
Copy link

pepa65 commented Dec 4, 2023

Here's my Work in Progress (and mostly quick&dirty) fork with support for trashing images/videos while playing, similar to what the OP @knguyen0105 asked for: https://github.com/flesser/pigallery2/tree/trashsupport

Basically, once you enable the feature in config.json (Client.Trash.enabled), it shows an additional "Trash" button in the Lightbox (also listening to the Del key).

Trashing files is implemented server-side by moving them into a new subdirectory (Client.Trash.trashFolderName, defaults to _pigallery2_trash) inside each album, which can then be deleted manually on the server. (No Gui support for that yet).

Images can be restored by "trashing" them from the trash folder. In that case, they just get moved back one dir up into the original album.

It's all not really field-tested yet, use at your own risk!

Does this still work 4.5 years later?!?

Edit: Just checked it out, the file structure seems to have changed too much...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement extension Features that won't go to the main app, but should be possible to implement them as extension
Projects
None yet
Development

No branches or pull requests

6 participants