Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): improve reliability of VM create / get operations #1431

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

bpg
Copy link
Owner

@bpg bpg commented Jul 8, 2024

  • Add retries to GET API calls, fix retrying on POST (VM create) API calls.
  • Minor fix in acceptance tests

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

- Add retries to GET API calls, fix retrying on POST (VM create) API calls.
- Minor fix in acceptance tests

Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
bpg added 4 commits July 8, 2024 13:47
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
@bpg bpg added the autoapprove label Jul 8, 2024
@bpg bpg enabled auto-merge (squash) July 8, 2024 18:17
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit d193abd into main Jul 8, 2024
8 checks passed
@bpg bpg deleted the fix-vm-get-create branch July 8, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant