Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct url for template download in container resource example #1563

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

seankoneill
Copy link
Contributor

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Description

#837 Changed the example container template url from:
http://download.proxmox.com/images/system/ubuntu-20.04-standard_20.04-1_amd64.tar.gz
to:
https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64.tar.gz.

The latter is a QCOW v2 image, so following the example as it's currently written will create a container that doesn't start: __lxc_start: 2114 Failed to spawn container "1234".

This PR just undoes this change in the docs so that following the example for the proxmox_virtual_environment_container resource works as expected.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

…ample

Signed-off-by: Sean O'Neill <sean.kenneth.oneill@gmail.com>
@bpg bpg changed the title fix(docs): correct url for template download in container resource ex… fix(docs): correct url for template download in container resource example Oct 3, 2024
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @seankoneill, good catch!

LGTM! 🚀

@bpg bpg merged commit 7266583 into bpg:main Oct 3, 2024
8 checks passed
@bpg
Copy link
Owner

bpg commented Oct 3, 2024

@all-contributors please add @seankoneill for docs

Copy link
Contributor

@bpg

I've put up a pull request to add @seankoneill! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants