Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for custom cloud-init vendor data file #162

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Conversation

bpg
Copy link
Owner

@bpg bpg commented Oct 26, 2022

Add new argument initialization.vendor_data_file_id to specify a file ID form snippets.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #111

Add new argument `initialization`.`vendor_data_file_id` to specify a file ID form snippets.
mergify[bot]
mergify bot previously approved these changes Oct 26, 2022
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved! 🤖

@bpg bpg added 📖 documentation Improvements or additions to documentation and removed docs labels Oct 26, 2022
@bpg bpg marked this pull request as draft October 30, 2022 02:25
@michalg91
Copy link
Contributor

Any chance to make it merged to master and published into terraform repository ;)?

@bpg
Copy link
Owner Author

bpg commented Nov 17, 2022

Hey @michalg91! The feature doesn't seem to work as I expected, and I didn't have enough time to debug it.
Would you mind to share an example of a vendor file that I can play with in tests? That will be a great help, as I don't use custom cloud-init in my environments.

@bpg
Copy link
Owner Author

bpg commented Nov 18, 2022

OK, I found more details on this and an example in https://bugzilla.proxmox.com/show_bug.cgi?id=2429, seems to be enough to create a proper test.

mergify[bot]
mergify bot previously approved these changes Nov 18, 2022
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg marked this pull request as ready for review November 18, 2022 00:58
mergify[bot]
mergify bot previously approved these changes Nov 18, 2022
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit 9e34dfb into main Nov 18, 2022
@bpg bpg deleted the cicustom-support branch November 18, 2022 01:33
@ghost ghost mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoapprove 📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cicustom vendor.yml
2 participants