fix(vm): Fix handling of empty kvm arguments #228

bpg · 2023-02-06T04:16:58Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #226

… is empty PVE returns a single space string (`" "`) when KVM arguments are not set.

mergify

🤖 LGTM! beep boop

bpg added 2 commits February 5, 2023 22:35

fix(vm): Fix false detection of a changed VM state when KVM arguments…

ce7edb3

… is empty PVE returns a single space string (`" "`) when KVM arguments are not set.

fix(vm): set KVM arguments only if non-empty

aa90bdb

product-auto-label bot added size: xs labels Feb 6, 2023

bpg added autoapprove and removed go labels Feb 6, 2023

mergify bot approved these changes Feb 6, 2023

View reviewed changes

bpg added the go label Feb 6, 2023

bpg enabled auto-merge (squash) February 6, 2023 04:18

bpg merged commit e2802d0 into main Feb 6, 2023

bpg deleted the fix-kvm-arguments branch February 6, 2023 04:18

ghost mentioned this pull request Feb 6, 2023

chore(main): release 0.12.0 #218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(vm): Fix handling of empty kvm arguments #228

fix(vm): Fix handling of empty kvm arguments #228

bpg commented Feb 6, 2023

mergify bot left a comment

fix(vm): Fix handling of empty kvm arguments #228

fix(vm): Fix handling of empty kvm arguments #228

Conversation

bpg commented Feb 6, 2023

Community Note

mergify bot left a comment

Choose a reason for hiding this comment